Skip to content

Commit

Permalink
USB: disable USB_MULTITHREAD_PROBE
Browse files Browse the repository at this point in the history
Disable the USB_MULTITHREAD_PROBE option because it causes crashes on
people's machines and they never remember to actually read the config
help files.

No one likes this, everyone hates it, I'm going to go eat worms...

The full logic will be ripped out later.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jan 22, 2007
1 parent 53e8f84 commit b1bf4f4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 24 deletions.
16 changes: 0 additions & 16 deletions drivers/usb/core/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,6 @@ config USB_SUSPEND

If you are unsure about this, say N here.

config USB_MULTITHREAD_PROBE
bool "USB Multi-threaded probe (EXPERIMENTAL)"
depends on USB && EXPERIMENTAL
default n
help
Say Y here if you want the USB core to spawn a new thread for
every USB device that is probed. This can cause a small speedup
in boot times on systems with a lot of different USB devices.

This option should be safe to enable, but if any odd probing
problems are found, please disable it, or dynamically turn it
off in the /sys/module/usbcore/parameters/multithread_probe
file

When in doubt, say N.

config USB_OTG
bool
depends on USB && EXPERIMENTAL
Expand Down
9 changes: 1 addition & 8 deletions drivers/usb/core/hub.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,7 @@ static DECLARE_WAIT_QUEUE_HEAD(khubd_wait);
static struct task_struct *khubd_task;

/* multithreaded probe logic */
static int multithread_probe =
#ifdef CONFIG_USB_MULTITHREAD_PROBE
1;
#else
0;
#endif
module_param(multithread_probe, bool, S_IRUGO);
MODULE_PARM_DESC(multithread_probe, "Run each USB device probe in a new thread");
static int multithread_probe = 0;

/* cycle leds on hubs that aren't blinking for attention */
static int blinkenlights = 0;
Expand Down

0 comments on commit b1bf4f4

Please sign in to comment.