Skip to content

Commit

Permalink
ACPI / PM: Expose current status of ACPI power resources
Browse files Browse the repository at this point in the history
Since ACPI power resources are going to be used more extensively on
new hardware platforms, it becomes necessary for user space (powertop
in particular) to observe some properties of those resources for
diagnostics purposes.

For this reason, expose the current status of each ACPI power
resource to user space via sysfs by adding a new resource_in_use
attribute to the sysfs directory representing the given power
resource.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Rafael J. Wysocki committed Jan 24, 2013
1 parent 836aedb commit b1c0f99
Show file tree
Hide file tree
Showing 4 changed files with 41 additions and 1 deletion.
12 changes: 12 additions & 0 deletions Documentation/ABI/testing/sysfs-devices-resource_in_use
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
What: /sys/devices/.../resource_in_use
Date: January 2013
Contact: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Description:
The /sys/devices/.../resource_in_use attribute is only present
for device objects representing ACPI power resources.

If present, it contains a number (0 or 1) representing the
current status of the given power resource (0 means that the
resource is not in use and therefore it has been turned off).

This attribute is read-only.
26 changes: 25 additions & 1 deletion drivers/acpi/power.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,20 @@ static DEFINE_MUTEX(power_resource_list_lock);
Power Resource Management
-------------------------------------------------------------------------- */

static inline
struct acpi_power_resource *to_power_resource(struct acpi_device *device)
{
return container_of(device, struct acpi_power_resource, device);
}

static struct acpi_power_resource *acpi_power_get_context(acpi_handle handle)
{
struct acpi_device *device;

if (acpi_bus_get_device(handle, &device))
return NULL;

return container_of(device, struct acpi_power_resource, device);
return to_power_resource(device);
}

static int acpi_power_resources_list_add(acpi_handle handle,
Expand Down Expand Up @@ -678,6 +684,21 @@ static void acpi_release_power_resource(struct device *dev)
kfree(resource);
}

static ssize_t acpi_power_in_use_show(struct device *dev,
struct device_attribute *attr,
char *buf) {
struct acpi_power_resource *resource;

resource = to_power_resource(to_acpi_device(dev));
return sprintf(buf, "%u\n", !!resource->ref_count);
}
static DEVICE_ATTR(resource_in_use, 0444, acpi_power_in_use_show, NULL);

static void acpi_power_sysfs_remove(struct acpi_device *device)
{
device_remove_file(&device->dev, &dev_attr_resource_in_use);
}

int acpi_add_power_resource(acpi_handle handle)
{
struct acpi_power_resource *resource;
Expand Down Expand Up @@ -725,6 +746,9 @@ int acpi_add_power_resource(acpi_handle handle)
if (result)
goto err;

if (!device_create_file(&device->dev, &dev_attr_resource_in_use))
device->remove = acpi_power_sysfs_remove;

mutex_lock(&power_resource_list_lock);
list_add(&resource->list_node, &acpi_power_resource_list);
mutex_unlock(&power_resource_list_lock);
Expand Down
3 changes: 3 additions & 0 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,9 @@ static void acpi_device_unregister(struct acpi_device *device)

acpi_power_add_remove_device(device, false);
acpi_device_remove_files(device);
if (device->remove)
device->remove(device);

device_del(&device->dev);
/*
* Drop the reference counts of all power resources the device depends
Expand Down
1 change: 1 addition & 0 deletions include/acpi/acpi_bus.h
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ struct acpi_device {
struct mutex physical_node_lock;
DECLARE_BITMAP(physical_node_id_bitmap, ACPI_MAX_PHYSICAL_NODE);
struct list_head power_dependent;
void (*remove)(struct acpi_device *);
};

static inline void *acpi_driver_data(struct acpi_device *d)
Expand Down

0 comments on commit b1c0f99

Please sign in to comment.