Skip to content

Commit

Permalink
team: remove usage of netdev_set_master()
Browse files Browse the repository at this point in the history
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jiri Pirko authored and David S. Miller committed Jan 4, 2013
1 parent 898e506 commit b1cc985
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/net/team/team.c
Original file line number Diff line number Diff line change
Expand Up @@ -1055,10 +1055,11 @@ static int team_port_add(struct team *team, struct net_device *port_dev)
}
}

err = netdev_set_master(port_dev, dev);
err = netdev_master_upper_dev_link(port_dev, dev);
if (err) {
netdev_err(dev, "Device %s failed to set master\n", portname);
goto err_set_master;
netdev_err(dev, "Device %s failed to set upper link\n",
portname);
goto err_set_upper_link;
}

err = netdev_rx_handler_register(port_dev, team_handle_frame,
Expand Down Expand Up @@ -1091,9 +1092,9 @@ static int team_port_add(struct team *team, struct net_device *port_dev)
netdev_rx_handler_unregister(port_dev);

err_handler_register:
netdev_set_master(port_dev, NULL);
netdev_upper_dev_unlink(port_dev, dev);

err_set_master:
err_set_upper_link:
team_port_disable_netpoll(port);

err_enable_netpoll:
Expand Down Expand Up @@ -1137,7 +1138,7 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
team_port_disable(team, port);
list_del_rcu(&port->list);
netdev_rx_handler_unregister(port_dev);
netdev_set_master(port_dev, NULL);
netdev_upper_dev_unlink(port_dev, dev);
team_port_disable_netpoll(port);
vlan_vids_del_by_dev(port_dev, dev);
dev_close(port_dev);
Expand Down

0 comments on commit b1cc985

Please sign in to comment.