Skip to content

Commit

Permalink
Driver core: use mutex instead of semaphore in DMA pool handler
Browse files Browse the repository at this point in the history
the DMA pool handler uses a semaphore as mutex. use the mutex API
instead of the (binary) semaphore

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Matthias Kaehlcke authored and Greg Kroah-Hartman committed Apr 27, 2007
1 parent 4f6e194 commit b2366d6
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions drivers/base/dmapool.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ struct dma_page { /* cacheable header for 'allocation' bytes */

#define POOL_TIMEOUT_JIFFIES ((100 /* msec */ * HZ) / 1000)

static DECLARE_MUTEX (pools_lock);
static DEFINE_MUTEX (pools_lock);

static ssize_t
show_pools (struct device *dev, struct device_attribute *attr, char *buf)
Expand All @@ -55,7 +55,7 @@ show_pools (struct device *dev, struct device_attribute *attr, char *buf)
size -= temp;
next += temp;

down (&pools_lock);
mutex_lock(&pools_lock);
list_for_each_entry(pool, &dev->dma_pools, pools) {
unsigned pages = 0;
unsigned blocks = 0;
Expand All @@ -73,7 +73,7 @@ show_pools (struct device *dev, struct device_attribute *attr, char *buf)
size -= temp;
next += temp;
}
up (&pools_lock);
mutex_unlock(&pools_lock);

return PAGE_SIZE - size;
}
Expand Down Expand Up @@ -143,7 +143,7 @@ dma_pool_create (const char *name, struct device *dev,
if (dev) {
int ret;

down (&pools_lock);
mutex_lock(&pools_lock);
if (list_empty (&dev->dma_pools))
ret = device_create_file (dev, &dev_attr_pools);
else
Expand All @@ -155,7 +155,7 @@ dma_pool_create (const char *name, struct device *dev,
kfree(retval);
retval = NULL;
}
up (&pools_lock);
mutex_unlock(&pools_lock);
} else
INIT_LIST_HEAD (&retval->pools);

Expand Down Expand Up @@ -231,11 +231,11 @@ pool_free_page (struct dma_pool *pool, struct dma_page *page)
void
dma_pool_destroy (struct dma_pool *pool)
{
down (&pools_lock);
mutex_lock(&pools_lock);
list_del (&pool->pools);
if (pool->dev && list_empty (&pool->dev->dma_pools))
device_remove_file (pool->dev, &dev_attr_pools);
up (&pools_lock);
mutex_unlock(&pools_lock);

while (!list_empty (&pool->page_list)) {
struct dma_page *page;
Expand Down

0 comments on commit b2366d6

Please sign in to comment.