Skip to content

Commit

Permalink
V4L/DVB (10894): ISA radio drivers: improve kernel log message
Browse files Browse the repository at this point in the history
It's much nicer if the log message tells you which io ports are possible,
rather than having to run modinfo or look it up in the source or manual.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent ec632c8 commit b24c20c
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/media/radio/radio-aimslab.c
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ static int __init rtrack_init(void)
rt->io = io;

if (rt->io == -1) {
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x20f or 0x30f\n");
return -EINVAL;
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/radio/radio-aztech.c
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ static int __init aztech_init(void)
az->io = io;

if (az->io == -1) {
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x350 or 0x358\n");
return -EINVAL;
}

Expand Down
3 changes: 2 additions & 1 deletion drivers/media/radio/radio-cadet.c
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,8 @@ static int __init cadet_init(void)
/* Else we bail out */
if (dev->io < 0) {
#ifdef MODULE
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x330, 0x332, 0x334,\n");
v4l2_err(v4l2_dev, "0x336, 0x338, 0x33a, 0x33c or 0x33e\n");
#endif
goto fail;
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/radio/radio-terratec.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ static int __init terratec_init(void)
strlcpy(v4l2_dev->name, "terratec", sizeof(v4l2_dev->name));
tt->io = io;
if (tt->io == -1) {
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "you must set an I/O address with io=0x590 or 0x591\n");
return -EINVAL;
}
if (!request_region(tt->io, 2, "terratec")) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/radio/radio-trust.c
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ static int __init trust_init(void)
mutex_init(&tr->lock);

if (tr->io == -1) {
v4l2_err(v4l2_dev, "You must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "You must set an I/O address with io=0x0x350 or 0x358\n");
return -EINVAL;
}
if (!request_region(tr->io, 2, "Trust FM Radio")) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/radio/radio-zoltrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ static int __init zoltrix_init(void)
strlcpy(v4l2_dev->name, "zoltrix", sizeof(v4l2_dev->name));
zol->io = io;
if (zol->io == -1) {
v4l2_err(v4l2_dev, "You must set an I/O address with io=0x???\n");
v4l2_err(v4l2_dev, "You must set an I/O address with io=0x20c or 0x30c\n");
return -EINVAL;
}
if (zol->io != 0x20c && zol->io != 0x30c) {
Expand Down

0 comments on commit b24c20c

Please sign in to comment.