Skip to content

Commit

Permalink
[media] m5mols: introduce missing initialization
Browse files Browse the repository at this point in the history
The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Julia Lawall authored and Mauro Carvalho Chehab committed Sep 14, 2012
1 parent 780d617 commit b25b895
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/i2c/m5mols/m5mols_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -937,7 +937,7 @@ static int __devinit m5mols_probe(struct i2c_client *client,
if (!ret)
ret = m5mols_init_controls(sd);

m5mols_sensor_power(info, false);
ret = m5mols_sensor_power(info, false);
if (!ret)
return 0;
out_me:
Expand Down

0 comments on commit b25b895

Please sign in to comment.