Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 308799
b: refs/heads/master
c: 296838b
h: refs/heads/master
i:
  308797: 63c11dd
  308795: ec46442
  308791: 57d8251
  308783: d8c709c
  308767: 950624b
  308735: 3a272cb
v: v3
  • Loading branch information
Jeff Layton authored and Steve French committed May 17, 2012
1 parent 376d5d4 commit b260600
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d06b5056ae160453c4be17e24e8cf08d65f4569f
refs/heads/master: 296838b182ebad919074bf324e1667d28a04b936
13 changes: 13 additions & 0 deletions trunk/fs/cifs/connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -1244,6 +1244,8 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
char *string = NULL;
char *tmp_end, *value;
char delim;
bool cache_specified = false;
static bool cache_warned = false;

separator[0] = ',';
separator[1] = 0;
Expand Down Expand Up @@ -1455,13 +1457,15 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
vol->seal = 1;
break;
case Opt_direct:
cache_specified = true;
vol->direct_io = true;
vol->strict_io = false;
cERROR(1, "The \"directio\" option will be removed in "
"3.7. Please switch to the \"cache=none\" "
"option.");
break;
case Opt_strictcache:
cache_specified = true;
vol->direct_io = false;
vol->strict_io = true;
cERROR(1, "The \"strictcache\" option will be removed "
Expand Down Expand Up @@ -1888,6 +1892,7 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
goto cifs_parse_mount_err;
break;
case Opt_cache:
cache_specified = true;
string = match_strdup(args);
if (string == NULL)
goto out_nomem;
Expand Down Expand Up @@ -1938,6 +1943,14 @@ cifs_parse_mount_options(const char *mountdata, const char *devname,
printk(KERN_NOTICE "CIFS: ignoring forcegid mount option "
"specified with no gid= option.\n");

/* FIXME: remove this block in 3.7 */
if (!cache_specified && !cache_warned) {
cache_warned = true;
printk(KERN_NOTICE "CIFS: no cache= option specified, using "
"\"cache=loose\". This default will change "
"to \"cache=strict\" in 3.7.\n");
}

kfree(mountdata_copy);
return 0;

Expand Down

0 comments on commit b260600

Please sign in to comment.