Skip to content

Commit

Permalink
[media] cx25821: Remove useless struct i2c_algo_bit_data
Browse files Browse the repository at this point in the history
The field 'struct i2c_algo_bit_data i2c_algo' is wrongly confused with
struct i2c_algorithm. Moreover, i2c_algo field is not used since
i2c is registered using i2c_add_adpater() and not i2c_bit_add_bus().
Therefore, it's safe to remove it.
Tested by compilation only.

Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Ezequiel García authored and Mauro Carvalho Chehab committed Jul 30, 2012
1 parent 2728635 commit b26f453
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions drivers/media/video/cx25821/cx25821-i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,13 @@ int cx25821_i2c_register(struct cx25821_i2c *bus)

memcpy(&bus->i2c_adap, &cx25821_i2c_adap_template,
sizeof(bus->i2c_adap));
memcpy(&bus->i2c_algo, &cx25821_i2c_algo_template,
sizeof(bus->i2c_algo));
memcpy(&bus->i2c_client, &cx25821_i2c_client_template,
sizeof(bus->i2c_client));

bus->i2c_adap.dev.parent = &dev->pci->dev;

strlcpy(bus->i2c_adap.name, bus->dev->name, sizeof(bus->i2c_adap.name));

bus->i2c_algo.data = bus;
bus->i2c_adap.algo_data = bus;
i2c_set_adapdata(&bus->i2c_adap, &dev->v4l2_dev);
i2c_add_adapter(&bus->i2c_adap);
Expand Down
2 changes: 0 additions & 2 deletions drivers/media/video/cx25821/cx25821.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

#include <linux/pci.h>
#include <linux/i2c.h>
#include <linux/i2c-algo-bit.h>
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/sched.h>
Expand Down Expand Up @@ -213,7 +212,6 @@ struct cx25821_i2c {

/* i2c i/o */
struct i2c_adapter i2c_adap;
struct i2c_algo_bit_data i2c_algo;
struct i2c_client i2c_client;
u32 i2c_rc;

Expand Down

0 comments on commit b26f453

Please sign in to comment.