Skip to content

Commit

Permalink
pnpbios: propagate kthread_run() error
Browse files Browse the repository at this point in the history
- Error code from kthread_run() is now returned in pnpbios_thread_init()

- Remove variable which always was 0.

Signed-off-by: Erik Ekman <erik@kryo.se>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Erik Ekman authored and Linus Torvalds committed Apr 3, 2009
1 parent 8c65591 commit b277c88
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions drivers/pnp/pnpbios/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ struct pnp_dev_node_info node_info;

#ifdef CONFIG_HOTPLUG

static int unloading = 0;
static struct completion unload_sem;

/*
Expand Down Expand Up @@ -158,7 +157,7 @@ static int pnp_dock_thread(void *unused)
int docked = -1, d = 0;

set_freezable();
while (!unloading) {
while (1) {
int status;

/*
Expand Down Expand Up @@ -586,8 +585,8 @@ static int __init pnpbios_thread_init(void)
struct task_struct *task;
init_completion(&unload_sem);
task = kthread_run(pnp_dock_thread, NULL, "kpnpbiosd");
if (!IS_ERR(task))
unloading = 0;
if (IS_ERR(task))
return PTR_ERR(task);
}
#endif
return 0;
Expand Down

0 comments on commit b277c88

Please sign in to comment.