Skip to content

Commit

Permalink
ACPI: remove acpi_device.flags.compatible_ids
Browse files Browse the repository at this point in the history
We now keep a single list of IDs that includes both the _HID and any
_CIDs.  We no longer need to keep track of whether the device has a _CID.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Len Brown committed Sep 25, 2009
1 parent 7f47fa6 commit b2972f8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
15 changes: 4 additions & 11 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ static int create_modalias(struct acpi_device *acpi_dev, char *modalias,
int count;
struct acpi_hardware_id *id;

if (!acpi_dev->flags.hardware_id && !acpi_dev->flags.compatible_ids)
if (!acpi_dev->flags.hardware_id)
return -ENODEV;

len = snprintf(modalias, size, "acpi:");
Expand Down Expand Up @@ -209,7 +209,7 @@ static int acpi_device_setup_files(struct acpi_device *dev)
goto end;
}

if (dev->flags.hardware_id || dev->flags.compatible_ids) {
if (dev->flags.hardware_id) {
result = device_create_file(&dev->dev, &dev_attr_modalias);
if (result)
goto end;
Expand Down Expand Up @@ -239,7 +239,7 @@ static void acpi_device_remove_files(struct acpi_device *dev)
if (ACPI_SUCCESS(status))
device_remove_file(&dev->dev, &dev_attr_eject);

if (dev->flags.hardware_id || dev->flags.compatible_ids)
if (dev->flags.hardware_id)
device_remove_file(&dev->dev, &dev_attr_modalias);

if (dev->flags.hardware_id)
Expand Down Expand Up @@ -876,11 +876,6 @@ static int acpi_bus_get_flags(struct acpi_device *device)
if (ACPI_SUCCESS(status))
device->flags.dynamic_status = 1;

/* Presence of _CID indicates 'compatible_ids' */
status = acpi_get_handle(device->handle, "_CID", &temp);
if (ACPI_SUCCESS(status))
device->flags.compatible_ids = 1;

/* Presence of _RMV indicates 'removable' */
status = acpi_get_handle(device->handle, "_RMV", &temp);
if (ACPI_SUCCESS(status))
Expand Down Expand Up @@ -1125,10 +1120,8 @@ static void acpi_device_set_id(struct acpi_device *device)
if (cid_list)
for (i = 0; i < cid_list->count; i++)
acpi_add_id(device, cid_list->ids[i].string);
if (cid_add) {
if (cid_add)
acpi_add_id(device, cid_add);
device->flags.compatible_ids = 1;
}

kfree(info);
}
Expand Down
3 changes: 1 addition & 2 deletions include/acpi/acpi_bus.h
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ struct acpi_device_status {
struct acpi_device_flags {
u32 dynamic_status:1;
u32 hardware_id:1;
u32 compatible_ids:1;
u32 bus_address:1;
u32 unique_id:1;
u32 removable:1;
Expand All @@ -153,7 +152,7 @@ struct acpi_device_flags {
u32 performance_manageable:1;
u32 wake_capable:1; /* Wakeup(_PRW) supported? */
u32 force_power_state:1;
u32 reserved:19;
u32 reserved:20;
};

/* File System */
Expand Down

0 comments on commit b2972f8

Please sign in to comment.