Skip to content

Commit

Permalink
e1000: fix spinlock bug
Browse files Browse the repository at this point in the history
This patch fixes an obvious and nasty bug where we could exit the transmit
routine while holding tx_lock.

Signed-off-by:  Mitch Williams <mitch.a.williams@intel.com>
  • Loading branch information
Mitch Williams authored and Jeff Garzik committed Jun 23, 2005
1 parent a493604 commit b2b3d82
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/net/e1000/e1000_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2307,6 +2307,7 @@ e1000_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
tso = e1000_tso(adapter, skb);
if (tso < 0) {
dev_kfree_skb_any(skb);
spin_unlock_irqrestore(&adapter->tx_lock, flags);
return NETDEV_TX_OK;
}

Expand Down

0 comments on commit b2b3d82

Please sign in to comment.