Skip to content

Commit

Permalink
Bluetooth: Fix failure to release lock in read_index_list()
Browse files Browse the repository at this point in the history
If alloc_skb() fails in read_index_list() we'll return -ENOMEM without
releasing 'hci_dev_list_lock'.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
  • Loading branch information
Jesper Juhl authored and Gustavo F. Padovan committed Feb 8, 2011
1 parent 80f5585 commit b2c60d4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/bluetooth/mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,10 @@ static int read_index_list(struct sock *sk)

body_len = sizeof(*ev) + sizeof(*rp) + (2 * count);
skb = alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC);
if (!skb)
if (!skb) {
read_unlock(&hci_dev_list_lock);
return -ENOMEM;
}

hdr = (void *) skb_put(skb, sizeof(*hdr));
hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);
Expand Down

0 comments on commit b2c60d4

Please sign in to comment.