Skip to content

Commit

Permalink
arch/sh/drivers/dma/dma-sh.c: Correct use of ! and &
Browse files Browse the repository at this point in the history
In commit e6bafba, a bug was fixed that
involved converting !x & y to !(x & y).  The code below shows the same
pattern, and thus should perhaps be fixed in the same way.

This is not tested and clearly changes the semantics, so it is only
something to consider.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@ expression E1,E2; @@
(
  !E1 & !E2
|
- !E1 & E2
+ !(E1 & E2)
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Julia Lawall authored and Paul Mundt committed Feb 27, 2008
1 parent 96de1a8 commit b2d7c7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/sh/drivers/dma/dma-sh.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static irqreturn_t dma_tei(int irq, void *dev_id)

static int sh_dmac_request_dma(struct dma_channel *chan)
{
if (unlikely(!chan->flags & DMA_TEI_CAPABLE))
if (unlikely(!(chan->flags & DMA_TEI_CAPABLE)))
return 0;

return request_irq(get_dmte_irq(chan->chan), dma_tei,
Expand Down

0 comments on commit b2d7c7f

Please sign in to comment.