Skip to content

Commit

Permalink
ARM: s3c: i2c: add platform_device forward declaration
Browse files Browse the repository at this point in the history
A recent cleanup to the mach-osiris.c file is causing build errors
because the i2c-s3c2410.h header file is included before we see
the definition for platform_device. The fix is to make the header file
more robust against inclusion from other places. While this should
normally go through the i2c tree, the bug only exists in arm-soc
at the moment, so it's easier to fix it there before it goes upstream.

Without this patch, building s3c2410_defconfig results in:

arch/arm/mach-s3c24xx/mach-osiris.c:34:0:
include/linux/platform_data/i2c-s3c2410.h:37:26: warning: 'struct platform_device' declared inside parameter list [enabled by default]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-i2c@vger.kernel.org
Cc: Wolfram Sang <w.sang@pengutronix.de>
Cc: Ben Dooks <ben-linux@fluff.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
  • Loading branch information
Arnd Bergmann committed Feb 14, 2013
1 parent 81c724a commit b2dc0c2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/linux/platform_data/i2c-s3c2410.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

#define S3C_IICFLG_FILTER (1<<0) /* enable s3c2440 filter */

struct platform_device;

/**
* struct s3c2410_platform_i2c - Platform data for s3c I2C.
* @bus_num: The bus number to use (if possible).
Expand Down

0 comments on commit b2dc0c2

Please sign in to comment.