Skip to content

Commit

Permalink
percpu: use a kconfig variable to signal arch specific percpu setup
Browse files Browse the repository at this point in the history
The use of the __GENERIC_PERCPU is a bit problematic since arches
may want to run their own percpu setup while using the generic
percpu definitions. Replace it through a kconfig variable.

Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andi Kleen <ak@suse.de>
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Mike Travis <travis@sgi.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
travis@sgi.com authored and Ingo Molnar committed Jan 30, 2008
1 parent cf8fa92 commit b32ef63
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 7 deletions.
3 changes: 3 additions & 0 deletions arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ config GENERIC_TIME_VSYSCALL
bool
default y

config ARCH_SETS_UP_PER_CPU_AREA
def_bool y

config DMI
bool
default y
Expand Down
3 changes: 3 additions & 0 deletions arch/powerpc/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ config GENERIC_HARDIRQS
bool
default y

config ARCH_SETS_UP_PER_CPU_AREA
def_bool PPC64

config IRQ_PER_CPU
bool
default y
Expand Down
3 changes: 3 additions & 0 deletions arch/sparc64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ config AUDIT_ARCH
bool
default y

config ARCH_SETS_UP_PER_CPU_AREA
def_bool y

config ARCH_NO_VIRT_TO_BUS
def_bool y

Expand Down
3 changes: 3 additions & 0 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ config GENERIC_TIME_VSYSCALL
bool
default X86_64

config ARCH_SETS_UP_PER_CPU_AREA
def_bool X86_64

config ARCH_SUPPORTS_OPROFILE
bool
default y
Expand Down
1 change: 0 additions & 1 deletion include/asm-generic/percpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#include <linux/compiler.h>
#include <linux/threads.h>

#define __GENERIC_PER_CPU
#ifdef CONFIG_SMP

extern unsigned long __per_cpu_offset[NR_CPUS];
Expand Down
2 changes: 0 additions & 2 deletions include/asm-s390/percpu.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#include <linux/compiler.h>
#include <asm/lowcore.h>

#define __GENERIC_PER_CPU

/*
* s390 uses its own implementation for per cpu data, the offset of
* the cpu local data area is cached in the cpu's lowcore memory.
Expand Down
2 changes: 0 additions & 2 deletions include/asm-x86/percpu_32.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
* PER_CPU(cpu_gdt_descr, %ebx)
*/
#ifdef CONFIG_SMP
/* Same as generic implementation except for optimized local access. */
#define __GENERIC_PER_CPU

/* This is used for other cpus to find our section. */
extern unsigned long __per_cpu_offset[];
Expand Down
4 changes: 2 additions & 2 deletions init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ static inline void smp_prepare_cpus(unsigned int maxcpus) { }

#else

#ifdef __GENERIC_PER_CPU
#ifndef CONFIG_ARCH_SETS_UP_PER_CPU_AREA
unsigned long __per_cpu_offset[NR_CPUS] __read_mostly;

EXPORT_SYMBOL(__per_cpu_offset);
Expand All @@ -384,7 +384,7 @@ static void __init setup_per_cpu_areas(void)
ptr += size;
}
}
#endif /* !__GENERIC_PER_CPU */
#endif /* CONFIG_ARCH_SETS_UP_CPU_AREA */

/* Called by boot processor to activate the rest. */
static void __init smp_init(void)
Expand Down

0 comments on commit b32ef63

Please sign in to comment.