Skip to content

Commit

Permalink
staging/xgifb: Include sis headers
Browse files Browse the repository at this point in the history
This patch includes the headers of the sis driver and reorders some
includes.

Since the xgi driver used to redefine a lot of stuff from the sis
driver, we can simply include the headers of the sis driver itself, so
we can remove duplicated stuff later on.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Peter Huewe authored and Greg Kroah-Hartman committed Feb 9, 2012
1 parent e24b0a3 commit b33704d
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 2 deletions.
1 change: 1 addition & 0 deletions drivers/staging/xgifb/XGI_main.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include "XGIfb.h"
#include "vb_struct.h"
#include "../../video/sis/sis.h"
#include "vb_def.h"

#define XGIFAIL(x) do { printk(x "\n"); return -EINVAL; } while (0)
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/xgifb/XGIfb.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#include <linux/ioctl.h>
#include <linux/types.h>

#include "vb_struct.h"
#include "vgatypes.h"
#include "vb_struct.h"

enum xgifb_display_type {
XGIFB_DISP_NONE = 0,
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/xgifb/vb_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
#include <linux/pci.h>
#include <linux/vmalloc.h>

#include "vgatypes.h"
#include "XGIfb.h"
#include "vgatypes.h"

#include "vb_def.h"
#include "vb_struct.h"
Expand Down
1 change: 1 addition & 0 deletions drivers/staging/xgifb/vb_struct.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ struct XGI_LCDDataStruct {
unsigned short LCDVT;
};

#include "../../video/sis/vstruct.h"

struct XGI_LVDSCRT1HDataStruct {
unsigned char Reg[8];
Expand Down
9 changes: 9 additions & 0 deletions drivers/staging/xgifb/vgatypes.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
#define _VGATYPES_

#include <linux/ioctl.h>
#include <linux/fb.h> /* for struct fb_var_screeninfo for sis.h */
#include "../../video/sis/vgatypes.h"
#include "../../video/sis/sis.h" /* for LCD_TYPE */

#ifndef XGI_VB_CHIP_TYPE
enum XGI_VB_CHIP_TYPE {
Expand All @@ -19,6 +22,12 @@ enum XGI_VB_CHIP_TYPE {
};
#endif


#define XGI_LCD_TYPE
/* Since the merge with video/sis the LCD_TYPEs are used from
drivers/video/sis/sis.h . Nevertheless we keep this (for the moment) for
future reference until the code is merged completely and we are sure
nothing of this should be added to the sis.h header */
#ifndef XGI_LCD_TYPE
enum XGI_LCD_TYPE {
LCD_INVALID = 0,
Expand Down

0 comments on commit b33704d

Please sign in to comment.