Skip to content

Commit

Permalink
[media] em28xx: save isoc endpoint number for DVB only if endpoint ha…
Browse files Browse the repository at this point in the history
…s alt settings with xMaxPacketSize != 0

X-Patchwork-Delegate: mchehab@redhat.com
In addition to commit 72cc9ba "em28xx: ignore isoc DVB USB endpoints with
wMaxPacketSize = 0 bytes for all alt settings" we should not save the endpoint
number of the isoc DVB endpoint before it has been validated.
While the current code works fine, dev->dvb_ep_isoc != 0 could be interpreted
as indicator that the device provides DVB support.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Frank Schaefer authored and Mauro Carvalho Chehab committed Apr 25, 2013
1 parent cb132cd commit b3404a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/usb/em28xx/em28xx-cards.c
Original file line number Diff line number Diff line change
Expand Up @@ -3220,9 +3220,9 @@ static int em28xx_usb_probe(struct usb_interface *interface,
e->bEndpointAddress;
} else {
if (usb_endpoint_xfer_isoc(e)) {
dev->dvb_ep_isoc = e->bEndpointAddress;
if (size > dev->dvb_max_pkt_size_isoc) {
has_dvb = true; /* see NOTE (~) */
dev->dvb_ep_isoc = e->bEndpointAddress;
dev->dvb_max_pkt_size_isoc = size;
dev->dvb_alt_isoc = i;
}
Expand Down

0 comments on commit b3404a8

Please sign in to comment.