Skip to content

Commit

Permalink
drm/i915/bios: abstract finding VBT in BIOS to a separate function
Browse files Browse the repository at this point in the history
Improve clarity. No functional changes.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Jani Nikula authored and Daniel Vetter committed May 20, 2015
1 parent 4d70f38 commit b34a991
Showing 1 changed file with 18 additions and 11 deletions.
29 changes: 18 additions & 11 deletions drivers/gpu/drm/i915/intel_bios.c
Original file line number Diff line number Diff line change
Expand Up @@ -1235,6 +1235,22 @@ static const struct bdb_header *validate_vbt(const void *base, size_t size,
return bdb;
}

static const struct bdb_header *find_vbt(void *bios, size_t size)
{
const struct bdb_header *bdb = NULL;
size_t i;

/* Scour memory looking for the VBT signature. */
for (i = 0; i + 4 < size; i++) {
if (memcmp(bios + i, "$VBT", 4) == 0) {
bdb = validate_vbt(bios, size, bios + i, "PCI ROM");
break;
}
}

return bdb;
}

/**
* intel_parse_bios - find VBT and initialize settings from the BIOS
* @dev: DRM device
Expand Down Expand Up @@ -1263,22 +1279,13 @@ intel_parse_bios(struct drm_device *dev)
dev_priv->opregion.vbt, "OpRegion");

if (bdb == NULL) {
size_t i, size;
size_t size;

bios = pci_map_rom(pdev, &size);
if (!bios)
return -1;

/* Scour memory looking for the VBT signature */
for (i = 0; i + 4 < size; i++) {
if (memcmp(bios + i, "$VBT", 4) == 0) {
bdb = validate_vbt(bios, size,
bios + i,
"PCI ROM");
break;
}
}

bdb = find_vbt(bios, size);
if (!bdb) {
pci_unmap_rom(pdev, bios);
return -1;
Expand Down

0 comments on commit b34a991

Please sign in to comment.