Skip to content

Commit

Permalink
usb:hsotg:samsung: Remove Disconnect Interrupt handler
Browse files Browse the repository at this point in the history
The USB Disconnect Interrupt handler, according to specification,
is only working at HOST mode.

Samsung SoCs (e.g. Exynos4) are working at device mode, so
this interrupt is never caught.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Lukasz Majewski authored and Felipe Balbi committed May 4, 2012
1 parent 308d734 commit b3546c9
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/usb/gadget/s3c-hsotg.c
Original file line number Diff line number Diff line change
Expand Up @@ -2211,12 +2211,11 @@ static void s3c_hsotg_core_init(struct s3c_hsotg *hsotg)
/* Clear any pending interrupts */
writel(0xffffffff, hsotg->regs + S3C_GINTSTS);

writel(S3C_GINTSTS_DisconnInt | S3C_GINTSTS_SessReqInt |
writel(S3C_GINTSTS_ErlySusp | S3C_GINTSTS_SessReqInt |
S3C_GINTSTS_GOUTNakEff | S3C_GINTSTS_GINNakEff |
S3C_GINTSTS_ConIDStsChng | S3C_GINTSTS_USBRst |
S3C_GINTSTS_EnumDone | S3C_GINTSTS_OTGInt |
S3C_GINTSTS_USBSusp | S3C_GINTSTS_WkUpInt |
S3C_GINTSTS_ErlySusp,
S3C_GINTSTS_USBSusp | S3C_GINTSTS_WkUpInt,
hsotg->regs + S3C_GINTMSK);

if (using_dma(hsotg))
Expand Down Expand Up @@ -2339,13 +2338,6 @@ static irqreturn_t s3c_hsotg_irq(int irq, void *pw)
writel(otgint, hsotg->regs + S3C_GOTGINT);
}

if (gintsts & S3C_GINTSTS_DisconnInt) {
dev_dbg(hsotg->dev, "%s: DisconnInt\n", __func__);
writel(S3C_GINTSTS_DisconnInt, hsotg->regs + S3C_GINTSTS);

s3c_hsotg_disconnect_irq(hsotg);
}

if (gintsts & S3C_GINTSTS_SessReqInt) {
dev_dbg(hsotg->dev, "%s: SessReqInt\n", __func__);
writel(S3C_GINTSTS_SessReqInt, hsotg->regs + S3C_GINTSTS);
Expand Down

0 comments on commit b3546c9

Please sign in to comment.