---

yaml
---
r: 155683
b: refs/heads/master
c: 0a09f43
h: refs/heads/master
i:
  155681: cf48744
  155679: 0a4d277
v: v3

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: c9d4bc289cd1cd43c3cff97b73efe2b0b5098a92
+refs/heads/master: 0a09f4319c6d88c732ed46735f8584bbb95cac65

trunk/block/elevator.c

@@ -101,11 +101,16 @@ int elv_rq_merge_ok(struct request *rq, struct bio *bio)
 		return 0;
 
 	/*
-	 * Don't merge if failfast settings don't match
+	 * Don't merge if failfast settings don't match.
+	 *
+	 * FIXME: The negation in front of each condition is necessary
+	 * because bio and request flags use different bit positions
+	 * and the accessors return those bits directly.  This
+	 * ugliness will soon go away.
 	 */
-	if (bio_failfast_dev(bio)	!= blk_failfast_dev(rq)		||
-	    bio_failfast_transport(bio)	!= blk_failfast_transport(rq)	||
-	    bio_failfast_driver(bio)	!= blk_failfast_driver(rq))
+	if (!bio_failfast_dev(bio)	 != !blk_failfast_dev(rq)	||
+	    !bio_failfast_transport(bio) != !blk_failfast_transport(rq)	||
+	    !bio_failfast_driver(bio)	 != !blk_failfast_driver(rq))
 		return 0;
 
 	if (!elv_iosched_allow_merge(rq, bio))