Skip to content

Commit

Permalink
x86: use fixup_exception() in traps_64.c
Browse files Browse the repository at this point in the history
Use the fixup_exception() helper instead of the open-coded
search_extable() users.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Harvey Harrison authored and Ingo Molnar committed Jan 30, 2008
1 parent 318aa29 commit b3a5acc
Showing 1 changed file with 15 additions and 32 deletions.
47 changes: 15 additions & 32 deletions arch/x86/kernel/traps_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -601,19 +601,12 @@ static void __kprobes do_trap(int trapnr, int signr, char *str,
}


/* kernel trap */
{
const struct exception_table_entry *fixup;
fixup = search_exception_tables(regs->ip);
if (fixup)
regs->ip = fixup->fixup;
else {
tsk->thread.error_code = error_code;
tsk->thread.trap_no = trapnr;
die(str, regs, error_code);
}
return;
if (!fixup_exception(regs)) {
tsk->thread.error_code = error_code;
tsk->thread.trap_no = trapnr;
die(str, regs, error_code);
}
return;
}

#define DO_ERROR(trapnr, signr, str, name) \
Expand Down Expand Up @@ -703,22 +696,15 @@ asmlinkage void __kprobes do_general_protection(struct pt_regs * regs,
return;
}

/* kernel gp */
{
const struct exception_table_entry *fixup;
fixup = search_exception_tables(regs->ip);
if (fixup) {
regs->ip = fixup->fixup;
return;
}
if (fixup_exception(regs))
return;

tsk->thread.error_code = error_code;
tsk->thread.trap_no = 13;
if (notify_die(DIE_GPF, "general protection fault", regs,
error_code, 13, SIGSEGV) == NOTIFY_STOP)
return;
die("general protection fault", regs, error_code);
}
tsk->thread.error_code = error_code;
tsk->thread.trap_no = 13;
if (notify_die(DIE_GPF, "general protection fault", regs,
error_code, 13, SIGSEGV) == NOTIFY_STOP)
return;
die("general protection fault", regs, error_code);
}

static __kprobes void
Expand Down Expand Up @@ -910,12 +896,9 @@ asmlinkage void __kprobes do_debug(struct pt_regs * regs,

static int kernel_math_error(struct pt_regs *regs, const char *str, int trapnr)
{
const struct exception_table_entry *fixup;
fixup = search_exception_tables(regs->ip);
if (fixup) {
regs->ip = fixup->fixup;
if (fixup_exception(regs))
return 1;
}

notify_die(DIE_GPF, str, regs, 0, trapnr, SIGFPE);
/* Illegal floating point operation in the kernel */
current->thread.trap_no = trapnr;
Expand Down

0 comments on commit b3a5acc

Please sign in to comment.