Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 307578
b: refs/heads/master
c: d33ec3b
h: refs/heads/master
v: v3
  • Loading branch information
Clemens Ladisch authored and Stefan Richter committed Apr 17, 2012
1 parent 796d832 commit b3ace07
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8a8c47364eef8595e05b5bf53352aa6f16784356
refs/heads/master: d33ec3b55e91f1c285099fee731b79a722d10fe6
9 changes: 3 additions & 6 deletions trunk/drivers/firewire/core-device.c
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ static int read_config_rom(struct fw_device *device, int generation)
if (read_rom(device, generation, i, &rom[i]) != RCODE_COMPLETE)
goto out;
/*
* As per IEEE1212 7.2, during power-up, devices can
* As per IEEE1212 7.2, during initialization, devices can
* reply with a 0 for the first quadlet of the config
* rom to indicate that they are booting (for example,
* if the firmware is on the disk of a external
Expand Down Expand Up @@ -1071,7 +1071,6 @@ static void fw_device_init(struct work_struct *work)

enum {
REREAD_BIB_ERROR,
REREAD_BIB_GONE,
REREAD_BIB_UNCHANGED,
REREAD_BIB_CHANGED,
};
Expand All @@ -1087,7 +1086,8 @@ static int reread_config_rom(struct fw_device *device, int generation)
return REREAD_BIB_ERROR;

if (i == 0 && q == 0)
return REREAD_BIB_GONE;
/* inaccessible (see read_config_rom); retry later */
return REREAD_BIB_ERROR;

if (q != device->config_rom[i])
return REREAD_BIB_CHANGED;
Expand All @@ -1114,9 +1114,6 @@ static void fw_device_refresh(struct work_struct *work)
}
goto give_up;

case REREAD_BIB_GONE:
goto gone;

case REREAD_BIB_UNCHANGED:
if (atomic_cmpxchg(&device->state,
FW_DEVICE_INITIALIZING,
Expand Down

0 comments on commit b3ace07

Please sign in to comment.