Skip to content

Commit

Permalink
[SCSI] fcoe: remove a stray unlock
Browse files Browse the repository at this point in the history
We moved the locking in dd060e7 "[SCSI] fcoe: remove frame dropping
code from fcoe_percpu_clean" but this unlock was missed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Dan Carpenter authored and James Bottomley committed May 10, 2012
1 parent d227f02 commit b3b8abd
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/scsi/fcoe/fcoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -2294,10 +2294,9 @@ static void fcoe_percpu_clean(struct fc_lport *lport)
continue;

skb = dev_alloc_skb(0);
if (!skb) {
spin_unlock_bh(&pp->fcoe_rx_list.lock);
if (!skb)
continue;
}

skb->destructor = fcoe_percpu_flush_done;

spin_lock_bh(&pp->fcoe_rx_list.lock);
Expand Down

0 comments on commit b3b8abd

Please sign in to comment.