Skip to content

Commit

Permalink
usb: musb: dsps: use platform_device_unregister in dsps_delete_musb_p…
Browse files Browse the repository at this point in the history
…dev()

platform_device_unregister() only calls platform_device_del() and
platform_device_put(), thus use platform_device_unregister() to
simplify the code.

Also the documents in platform.c shows that platform_device_del
and platform_device_put must _only_ be externally called in error
cases.  All other usage is a bug.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Felipe Balbi <balbi@ti.com>
  • Loading branch information
Wei Yongjun authored and Felipe Balbi committed Oct 26, 2012
1 parent 12a71f5 commit b415c8f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/usb/musb/musb_dsps.c
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,7 @@ static int __devinit dsps_create_musb_pdev(struct dsps_glue *glue, u8 id)
static void dsps_delete_musb_pdev(struct dsps_glue *glue, u8 id)
{
musb_put_id(glue->dev, glue->musb[id]->id);
platform_device_del(glue->musb[id]);
platform_device_put(glue->musb[id]);
platform_device_unregister(glue->musb[id]);
}

static int __devinit dsps_probe(struct platform_device *pdev)
Expand Down

0 comments on commit b415c8f

Please sign in to comment.