Skip to content

Commit

Permalink
staging: line6: drop unused line6_devices[] array
Browse files Browse the repository at this point in the history
There is no reason to limit the number of line6 devices.  Drop the
static array.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stefan Hajnoczi authored and Greg Kroah-Hartman committed Oct 22, 2012
1 parent 8d64c32 commit b430b3d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 21 deletions.
20 changes: 1 addition & 19 deletions drivers/staging/line6/driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ static const char line6_request_version[] = {
0xf0, 0x7e, 0x7f, 0x06, 0x01, 0xf7
};

struct usb_line6 *line6_devices[LINE6_MAX_DEVICES];

/**
Class for asynchronous messages.
*/
Expand Down Expand Up @@ -740,7 +738,6 @@ static int line6_probe(struct usb_interface *interface,
struct usb_device *usbdev;
struct usb_line6 *line6;
const struct line6_properties *properties;
int devnum;
int interface_number, alternate = 0;
int product;
int size = 0;
Expand Down Expand Up @@ -774,16 +771,6 @@ static int line6_probe(struct usb_interface *interface,
goto err_put;
}

/* find free slot in device table: */
for (devnum = 0; devnum < LINE6_MAX_DEVICES; ++devnum)
if (line6_devices[devnum] == NULL)
break;

if (devnum == LINE6_MAX_DEVICES) {
ret = -ENODEV;
goto err_put;
}

/* initialize device info: */
properties = &line6_properties_table[devtype];
dev_info(&interface->dev, "Line6 %s found\n", properties->name);
Expand Down Expand Up @@ -1112,7 +1099,6 @@ static int line6_probe(struct usb_interface *interface,

dev_info(&interface->dev, "Line6 %s now attached\n",
line6->properties->name);
line6_devices[devnum] = line6;

switch (product) {
case LINE6_DEVID_PODX3:
Expand Down Expand Up @@ -1141,7 +1127,7 @@ static void line6_disconnect(struct usb_interface *interface)
{
struct usb_line6 *line6;
struct usb_device *usbdev;
int interface_number, i;
int interface_number;

if (interface == NULL)
return;
Expand Down Expand Up @@ -1214,10 +1200,6 @@ static void line6_disconnect(struct usb_interface *interface)

dev_info(&interface->dev, "Line6 %s now disconnected\n",
line6->properties->name);

for (i = LINE6_MAX_DEVICES; i--;)
if (line6_devices[i] == line6)
line6_devices[i] = NULL;
}

line6_destruct(interface);
Expand Down
2 changes: 0 additions & 2 deletions drivers/staging/line6/driver.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#endif

#define LINE6_TIMEOUT 1
#define LINE6_MAX_DEVICES 8
#define LINE6_BUFSIZE_LISTEN 32
#define LINE6_MESSAGE_MAXLEN 256

Expand Down Expand Up @@ -78,7 +77,6 @@ do { \
} while (0)

extern const unsigned char line6_midi_id[3];
extern struct usb_line6 *line6_devices[LINE6_MAX_DEVICES];

static const int SYSEX_DATA_OFS = sizeof(line6_midi_id) + 3;
static const int SYSEX_EXTRA_SIZE = sizeof(line6_midi_id) + 4;
Expand Down

0 comments on commit b430b3d

Please sign in to comment.