Skip to content

Commit

Permalink
Input: fm801-gp - handle errors from pci_enable_device()
Browse files Browse the repository at this point in the history
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Jeff Garzik authored and Dmitry Torokhov committed Oct 12, 2006
1 parent 23de151 commit b435fdc
Showing 1 changed file with 15 additions and 7 deletions.
22 changes: 15 additions & 7 deletions drivers/input/gameport/fm801-gp.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,19 @@ static int __devinit fm801_gp_probe(struct pci_dev *pci, const struct pci_device
{
struct fm801_gp *gp;
struct gameport *port;
int error;

gp = kzalloc(sizeof(struct fm801_gp), GFP_KERNEL);
port = gameport_allocate_port();
if (!gp || !port) {
printk(KERN_ERR "fm801-gp: Memory allocation failed\n");
kfree(gp);
gameport_free_port(port);
return -ENOMEM;
error = -ENOMEM;
goto err_out_free;
}

pci_enable_device(pci);
error = pci_enable_device(pci);
if (error)
goto err_out_free;

port->open = fm801_gp_open;
#ifdef HAVE_COOKED
Expand All @@ -108,9 +110,8 @@ static int __devinit fm801_gp_probe(struct pci_dev *pci, const struct pci_device
if (!gp->res_port) {
printk(KERN_DEBUG "fm801-gp: unable to grab region 0x%x-0x%x\n",
port->io, port->io + 0x0f);
gameport_free_port(port);
kfree(gp);
return -EBUSY;
error = -EBUSY;
goto err_out_disable_dev;
}

pci_set_drvdata(pci, gp);
Expand All @@ -119,6 +120,13 @@ static int __devinit fm801_gp_probe(struct pci_dev *pci, const struct pci_device
gameport_register_port(port);

return 0;

err_out_disable_dev:
pci_disable_device(pci);
err_out_free:
gameport_free_port(port);
kfree(gp);
return error;
}

static void __devexit fm801_gp_remove(struct pci_dev *pci)
Expand Down

0 comments on commit b435fdc

Please sign in to comment.