Skip to content

Commit

Permalink
[PATCH] OOM can panic due to processes stuck in __alloc_pages()
Browse files Browse the repository at this point in the history
OOM can panic due to the processes stuck in __alloc_pages() doing infinite
rebalance loop while no memory can be reclaimed.  OOM killer tries to kill
some processes, but unfortunetaly, rebalance label was moved by someone
below the TIF_MEMDIE check, so buddy allocator doesn't see that process is
OOM-killed and it can simply fail the allocation :/

Observed in reality on RHEL4(2.6.9)+OpenVZ kernel when a user doing some
memory allocation tricks triggered OOM panic.

Signed-off-by: Denis Lunev <den@sw.ru>
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Kirill Korotaev authored and Linus Torvalds committed Dec 7, 2006
1 parent a3eea48 commit b43a57b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mm/page_alloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1180,6 +1180,7 @@ __alloc_pages(gfp_t gfp_mask, unsigned int order,

/* This allocation should allow future memory freeing. */

rebalance:
if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE)))
&& !in_interrupt()) {
if (!(gfp_mask & __GFP_NOMEMALLOC)) {
Expand All @@ -1201,7 +1202,6 @@ __alloc_pages(gfp_t gfp_mask, unsigned int order,
if (!wait)
goto nopage;

rebalance:
cond_resched();

/* We now go into synchronous reclaim */
Expand Down

0 comments on commit b43a57b

Please sign in to comment.