Skip to content

Commit

Permalink
[media] Staging/media: Use dev_ printks in go7007/wis-tw2804.c
Browse files Browse the repository at this point in the history
fixed below checkpatch warning.
- WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
- WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(...  to printk(KERN_DEBUG ...

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
YAMANE Toshiaki authored and Mauro Carvalho Chehab committed Dec 21, 2012
1 parent b91c78e commit b441d03
Showing 1 changed file with 13 additions and 11 deletions.
24 changes: 13 additions & 11 deletions drivers/staging/media/go7007/wis-tw2804.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,30 +128,32 @@ static int wis_tw2804_command(struct i2c_client *client,
int *input = arg;

if (*input < 0 || *input > 3) {
printk(KERN_ERR "wis-tw2804: channel %d is not "
"between 0 and 3!\n", *input);
dev_err(&client->dev,
"channel %d is not between 0 and 3!\n", *input);
return 0;
}
dec->channel = *input;
printk(KERN_DEBUG "wis-tw2804: initializing TW2804 "
"channel %d\n", dec->channel);
dev_dbg(&client->dev, "initializing TW2804 channel %d\n",
dec->channel);
if (dec->channel == 0 &&
write_regs(client, global_registers, 0) < 0) {
printk(KERN_ERR "wis-tw2804: error initializing "
"TW2804 global registers\n");
dev_err(&client->dev,
"error initializing TW2804 global registers\n");
return 0;
}
if (write_regs(client, channel_registers, dec->channel) < 0) {
printk(KERN_ERR "wis-tw2804: error initializing "
"TW2804 channel %d\n", dec->channel);
dev_err(&client->dev,
"error initializing TW2804 channel %d\n",
dec->channel);
return 0;
}
return 0;
}

if (dec->channel < 0) {
printk(KERN_DEBUG "wis-tw2804: ignoring command %08x until "
"channel number is set\n", cmd);
dev_dbg(&client->dev,
"ignoring command %08x until channel number is set\n",
cmd);
return 0;
}

Expand Down Expand Up @@ -311,7 +313,7 @@ static int wis_tw2804_probe(struct i2c_client *client,
dec->hue = 128;
i2c_set_clientdata(client, dec);

printk(KERN_DEBUG "wis-tw2804: creating TW2804 at address %d on %s\n",
dev_dbg(&client->dev, "creating TW2804 at address %d on %s\n",
client->addr, adapter->name);

return 0;
Expand Down

0 comments on commit b441d03

Please sign in to comment.