Skip to content

Commit

Permalink
x86: drop REBOOT_CF9_COND from reboot fallback chain
Browse files Browse the repository at this point in the history
Impact: Reverts sequence of reboot fallbacks

Checkin 14d7ca5 changed the default
reboot method to "pci", a.k.a. port CF9.  Unfortunately this has been
shown to cause lockups on at least two systems for which REBOOT_KBD
worked, both Thinkpads with Intel chipsets.  Checkin
3889d0c reverted the default, but did
not revert the fallback chain.  This checkin reverts the fallback
chain; port CF9 is now only done by explicit "reboot=pci" or a future
potential DMI key.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
  • Loading branch information
H. Peter Anvin committed Nov 24, 2008
1 parent 3889d0c commit b47b928
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/x86/kernel/reboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -384,20 +384,20 @@ static void native_machine_emergency_restart(void)
load_idt(&no_idt);
__asm__ __volatile__("int3");

reboot_type = BOOT_CF9_COND;
reboot_type = BOOT_KBD;
break;

#ifdef CONFIG_X86_32
case BOOT_BIOS:
machine_real_restart(jump_to_bios, sizeof(jump_to_bios));

reboot_type = BOOT_CF9_COND;
reboot_type = BOOT_KBD;
break;
#endif

case BOOT_ACPI:
acpi_reboot();
reboot_type = BOOT_CF9_COND;
reboot_type = BOOT_KBD;
break;

case BOOT_EFI:
Expand All @@ -406,7 +406,7 @@ static void native_machine_emergency_restart(void)
EFI_RESET_WARM :
EFI_RESET_COLD,
EFI_SUCCESS, 0, NULL);
reboot_type = BOOT_CF9_COND;
reboot_type = BOOT_KBD;
break;

case BOOT_CF9:
Expand Down

0 comments on commit b47b928

Please sign in to comment.