Skip to content

Commit

Permalink
[PATCH] powerpc: remove useless call to touch_softlockup_watchdog
Browse files Browse the repository at this point in the history
It turns out that we can't stop the watchdog from
triggering here.  If we touch the timer (which just uses the current jiffie
value) before we enable interrupts, it does nothing because jiffies
are not mass-updated until after we enable interrupts.  If we touch the
timer after we enable interrupts, its too late because the softlockup
watchdog will already have triggered.  The touch_softlockup_watchdog
call removed below does nothing.

Signed-off-by: Dave Boutcher <sleddog@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Dave C Boutcher authored and Paul Mackerras committed Feb 7, 2006
1 parent 82a4df7 commit b4fd884
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions arch/powerpc/kernel/rtas.c
Original file line number Diff line number Diff line change
Expand Up @@ -599,10 +599,6 @@ static void rtas_percpu_suspend_me(void *info)
}

out:
/* before we restore interrupts, make sure we don't
* generate a spurious soft lockup errors
*/
touch_softlockup_watchdog();
local_irq_restore(flags);
return;
}
Expand Down

0 comments on commit b4fd884

Please sign in to comment.