Skip to content

Commit

Permalink
ipack/devices/ipoctal: setup TTY_NORMAL flag for each character.
Browse files Browse the repository at this point in the history
In case of several characters present in RxFIFO, they will have the flag of the
previous one, no matter if the actual character was received properly or not.

This patch fixes this bug.

Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Samuel Iglesias Gonsalvez authored and Greg Kroah-Hartman committed Jan 16, 2013
1 parent a1da13a commit b5071f2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/ipack/devices/ipoctal.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,12 @@ static void ipoctal_irq_rx(struct ipoctal_channel *channel,
struct tty_struct *tty, u8 sr)
{
unsigned char value;
unsigned char flag = TTY_NORMAL;
unsigned char flag;
u8 isr;

do {
value = ioread8(&channel->regs->r.rhr);
flag = TTY_NORMAL;
/* Error: count statistics */
if (sr & SR_ERROR) {
iowrite8(CR_CMD_RESET_ERR_STATUS, &channel->regs->w.cr);
Expand Down

0 comments on commit b5071f2

Please sign in to comment.