Skip to content

Commit

Permalink
Documentation/SubmitChecklist: add rule #1
Browse files Browse the repository at this point in the history
Add header file requirements.  Compliments of Stephen Rothwell.

Stephen calls this Rule #1, so I put it there, but I didn't want to demote
any of the others in the list, so I made one of them number 2b.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Randy Dunlap authored and Linus Torvalds committed Mar 12, 2010
1 parent 70bace8 commit b5247c8
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions Documentation/SubmitChecklist
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@ Documentation/SubmittingPatches and elsewhere regarding submitting Linux
kernel patches.


1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
1: If you use a facility then #include the file that defines/declares
that facility. Don't depend on other header files pulling in ones
that you use.

2: Builds cleanly with applicable or modified CONFIG options =y, =m, and
=n. No gcc warnings/errors, no linker warnings/errors.

2: Passes allnoconfig, allmodconfig
2b: Passes allnoconfig, allmodconfig

3: Builds on multiple CPU architectures by using local cross-compile tools
or some other build farm.
Expand Down

0 comments on commit b5247c8

Please sign in to comment.