Skip to content

Commit

Permalink
ACPI: Register EC io ports in /proc/ioports
Browse files Browse the repository at this point in the history
Formerly these have been exposed through /proc/..
Better register them where all IO ports should get registered
and scream loud if someone else claims to use them.

EC data and command port typically should show up like this
then:
...
  0060-0060 : keyboard
  0062-0062 : EC data
  0064-0064 : keyboard
  0066-0066 : EC command
  0070-0071 : rtc0
...

Signed-off-by: Thomas Renninger <trenn@suse.de>

CC: Alexey Starikovskiy <astarikovskiy@suse.de>
CC: Len Brown <lenb@kernel.org>
CC: linux-kernel@vger.kernel.org
CC: linux-acpi@vger.kernel.org
CC: Bjorn Helgaas <bjorn.helgaas@hp.com>
CC: platform-driver-x86@vger.kernel.org
Signed-off-by: Matthew Garrett <mjg@redhat.com>
  • Loading branch information
Thomas Renninger authored and Matthew Garrett committed Aug 3, 2010
1 parent 9827886 commit b52e042
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions drivers/acpi/ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -864,10 +864,18 @@ ec_parse_io_ports(struct acpi_resource *resource, void *context)
* the second address region returned is the status/command
* port.
*/
if (ec->data_addr == 0)
if (ec->data_addr == 0) {
ec->data_addr = resource->data.io.minimum;
else if (ec->command_addr == 0)
WARN(!request_region(ec->data_addr, 1, "EC data"),
"Could not request EC data io port %lu",
ec->data_addr);
}
else if (ec->command_addr == 0) {
ec->command_addr = resource->data.io.minimum;
WARN(!request_region(ec->command_addr, 1, "EC command"),
"Could not request EC command io port %lu",
ec->command_addr);
}
else
return AE_CTRL_TERMINATE;

Expand Down

0 comments on commit b52e042

Please sign in to comment.