Skip to content

Commit

Permalink
via-velocity: S3 resume fix.
Browse files Browse the repository at this point in the history
Initially diagnosed on Ubuntu 11.04 with kernel 2.6.38.

velocity_close is not called during a suspend / resume cycle in this
driver and it has no business playing directly with power states.

Signed-off-by: David Lv <DavidLv@viatech.com.cn>
Acked-by: Francois Romieu <romieu@fr.zoreil.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David Lv authored and David S. Miller committed Feb 5, 2012
1 parent e6b4524 commit b530b19
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/ethernet/via/via-velocity.c
Original file line number Diff line number Diff line change
Expand Up @@ -2491,9 +2491,6 @@ static int velocity_close(struct net_device *dev)
if (dev->irq != 0)
free_irq(dev->irq, dev);

/* Power down the chip */
pci_set_power_state(vptr->pdev, PCI_D3hot);

velocity_free_rings(vptr);

vptr->flags &= (~VELOCITY_FLAGS_OPENED);
Expand Down

0 comments on commit b530b19

Please sign in to comment.