Skip to content

Commit

Permalink
V4L/DVB (8727): V4L1: make PMS not autoprobe when builtin.
Browse files Browse the repository at this point in the history
The old Mediavision Pro Movie Studio legacy ISA V4L1 driver was found to
hang the boot during Ingo Molnar's testing of randconfig kernels.  Have it
require a "pms.enable=1" kernel parameter to enable the driver when
builtin which avoids such problems.

This is a deprecated and, very likely, unused driver.  Nothing changes
modular behaviour moreover.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Rene Herman authored and Mauro Carvalho Chehab committed Sep 3, 2008
1 parent f46466e commit b54ff93
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions drivers/media/video/pms.c
Original file line number Diff line number Diff line change
Expand Up @@ -1019,10 +1019,22 @@ static int init_mediavision(void)
* Initialization and module stuff
*/

#ifndef MODULE
static int enable;
module_param(enable, int, 0);
#endif

static int __init init_pms_cards(void)
{
printk(KERN_INFO "Mediavision Pro Movie Studio driver 0.02\n");

#ifndef MODULE
if (!enable) {
printk(KERN_INFO "Not enabled\n");
return -ENODEV;
}
#endif

data_port = io_port +1;

if(init_mediavision())
Expand Down

0 comments on commit b54ff93

Please sign in to comment.