Skip to content

Commit

Permalink
staging: vme: tsi148: use list_for_each_safe when deleting resources …
Browse files Browse the repository at this point in the history
…in .remove

This fixes an oops when removing the module.

Signed-off-by: Emilio G. Cota <cota@braap.org>
Acked-by: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Emilio G. Cota authored and Greg Kroah-Hartman committed Nov 16, 2010
1 parent db6d8fc commit b558ba2
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/staging/vme/bridges/vme_tsi148.c
Original file line number Diff line number Diff line change
Expand Up @@ -2531,6 +2531,7 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
static void tsi148_remove(struct pci_dev *pdev)
{
struct list_head *pos = NULL;
struct list_head *tmplist;
struct vme_master_resource *master_image;
struct vme_slave_resource *slave_image;
struct vme_dma_resource *dma_ctrlr;
Expand Down Expand Up @@ -2589,21 +2590,21 @@ static void tsi148_remove(struct pci_dev *pdev)
tsi148_crcsr_exit(tsi148_bridge, pdev);

/* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->dma_resources) {
list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) {
dma_ctrlr = list_entry(pos, struct vme_dma_resource, list);
list_del(pos);
kfree(dma_ctrlr);
}

/* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->slave_resources) {
list_for_each_safe(pos, tmplist, &tsi148_bridge->slave_resources) {
slave_image = list_entry(pos, struct vme_slave_resource, list);
list_del(pos);
kfree(slave_image);
}

/* resources are stored in link list */
list_for_each(pos, &tsi148_bridge->master_resources) {
list_for_each_safe(pos, tmplist, &tsi148_bridge->master_resources) {
master_image = list_entry(pos, struct vme_master_resource,
list);
list_del(pos);
Expand Down

0 comments on commit b558ba2

Please sign in to comment.