Skip to content

Commit

Permalink
pnp: make the resource type an unsigned long
Browse files Browse the repository at this point in the history
PnP encodes the resource type directly as its struct resource->flags value
which is an unsigned long.  Make it so...

Signed-off-by: Rene Herman <rene.herman@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Acked-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Rene Herman authored and Linus Torvalds committed Oct 16, 2008
1 parent a63cc18 commit b563cf5
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/pnp/base.h
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ char *pnp_resource_type_name(struct resource *res);
void dbg_pnp_show_resources(struct pnp_dev *dev, char *desc);

void pnp_free_resources(struct pnp_dev *dev);
int pnp_resource_type(struct resource *res);
unsigned long pnp_resource_type(struct resource *res);

struct pnp_resource {
struct list_head list;
Expand Down
2 changes: 1 addition & 1 deletion drivers/pnp/quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ static void quirk_system_pci_resources(struct pnp_dev *dev)
*/
for_each_pci_dev(pdev) {
for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
unsigned int type;
unsigned long type;

type = pci_resource_flags(pdev, i) &
(IORESOURCE_IO | IORESOURCE_MEM);
Expand Down
4 changes: 2 additions & 2 deletions drivers/pnp/resource.c
Original file line number Diff line number Diff line change
Expand Up @@ -467,14 +467,14 @@ int pnp_check_dma(struct pnp_dev *dev, struct resource *res)
#endif
}

int pnp_resource_type(struct resource *res)
unsigned long pnp_resource_type(struct resource *res)
{
return res->flags & (IORESOURCE_IO | IORESOURCE_MEM |
IORESOURCE_IRQ | IORESOURCE_DMA);
}

struct resource *pnp_get_resource(struct pnp_dev *dev,
unsigned int type, unsigned int num)
unsigned long type, unsigned int num)
{
struct pnp_resource *pnp_res;
struct resource *res;
Expand Down
6 changes: 4 additions & 2 deletions include/linux/pnp.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ struct pnp_dev;
* Resource Management
*/
#ifdef CONFIG_PNP
struct resource *pnp_get_resource(struct pnp_dev *, unsigned int, unsigned int);
struct resource *pnp_get_resource(struct pnp_dev *dev, unsigned long type,
unsigned int num);
#else
static inline struct resource *pnp_get_resource(struct pnp_dev *dev, unsigned int type, unsigned int num)
static inline struct resource *pnp_get_resource(struct pnp_dev *dev,
unsigned long type, unsigned int num)
{
return NULL;
}
Expand Down

0 comments on commit b563cf5

Please sign in to comment.