Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 331587
b: refs/heads/master
c: c9b9253
h: refs/heads/master
i:
  331585: a324111
  331583: 6c7fb25
v: v3
  • Loading branch information
Anatol Pomozov authored and Theodore Ts'o committed Sep 18, 2012
1 parent 292d278 commit b570928
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b5e2368baeddf401bf3da9e364fc1c96676279cd
refs/heads/master: c9b92530a723ac5ef8e352885a1862b18f31b2f5
7 changes: 3 additions & 4 deletions trunk/fs/ext4/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,7 @@ int ext4_orphan_add(handle_t *handle, struct inode *inode)
struct ext4_iloc iloc;
int err = 0, rc;

if (!ext4_handle_valid(handle))
if (!EXT4_SB(sb)->s_journal)
return 0;

mutex_lock(&EXT4_SB(sb)->s_orphan_lock);
Expand Down Expand Up @@ -2443,8 +2443,7 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode)
struct ext4_iloc iloc;
int err = 0;

/* ext4_handle_valid() assumes a valid handle_t pointer */
if (handle && !ext4_handle_valid(handle))
if (!EXT4_SB(inode->i_sb)->s_journal)
return 0;

mutex_lock(&EXT4_SB(inode->i_sb)->s_orphan_lock);
Expand All @@ -2463,7 +2462,7 @@ int ext4_orphan_del(handle_t *handle, struct inode *inode)
* transaction handle with which to update the orphan list on
* disk, but we still need to remove the inode from the linked
* list in memory. */
if (sbi->s_journal && !handle)
if (!handle)
goto out;

err = ext4_reserve_inode_write(handle, inode, &iloc);
Expand Down

0 comments on commit b570928

Please sign in to comment.