Skip to content

Commit

Permalink
x86: provide connect_bsp_APIC for x86_64
Browse files Browse the repository at this point in the history
Although it is not really needed, we provide it to get
closer to i386. ifdefs around it are removed in smpboot.c

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber Costa authored and Ingo Molnar committed Jul 8, 2008
1 parent 3fde690 commit b584176
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
10 changes: 10 additions & 0 deletions arch/x86/kernel/apic_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -918,6 +918,8 @@ int __init APIC_init_uniprocessor(void)

verify_local_APIC();

connect_bsp_APIC();

physid_set_mask_of_physid(boot_cpu_physical_apicid, &phys_cpu_present_map);
apic_write(APIC_ID, SET_APIC_ID(boot_cpu_physical_apicid));

Expand Down Expand Up @@ -999,6 +1001,14 @@ asmlinkage void smp_error_interrupt(void)
irq_exit();
}

/**
* * connect_bsp_APIC - attach the APIC to the interrupt system
* */
void __init connect_bsp_APIC(void)
{
enable_apic_mode();
}

void disconnect_bsp_APIC(int virt_wire_setup)
{
/* Go back to Virtual Wire compatibility mode */
Expand Down
5 changes: 1 addition & 4 deletions arch/x86/kernel/smpboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -1116,9 +1116,7 @@ static int __init smp_sanity_check(unsigned max_cpus)

localise_nmi_watchdog();

#ifdef CONFIG_X86_32
connect_bsp_APIC();
#endif
setup_local_APIC();
end_local_APIC_setup();
return -1;
Expand Down Expand Up @@ -1173,9 +1171,8 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus)
}
preempt_enable();

#ifdef CONFIG_X86_32
connect_bsp_APIC();
#endif

/*
* Switch from PIC to APIC mode.
*/
Expand Down

0 comments on commit b584176

Please sign in to comment.