Skip to content

Commit

Permalink
[media] mn88473: Remove uneeded check before release_firmware()
Browse files Browse the repository at this point in the history
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
Markus Elfring authored and Mauro Carvalho Chehab committed Dec 4, 2014
1 parent e8379ec commit b591138
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/staging/media/mn88473/mn88473.c
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,7 @@ static int mn88473_init(struct dvb_frontend *fe)

return 0;
err:
if (fw)
release_firmware(fw);
release_firmware(fw);

dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;
Expand Down

0 comments on commit b591138

Please sign in to comment.