Skip to content

Commit

Permalink
mac80211: fix warnings in ieee80211_if_config
Browse files Browse the repository at this point in the history
The last warning can never trigger, and the explicit AP_VLAN
check is pointless if we move the config_interface check down,
in practice config_interface is required anyway.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Johannes Berg authored and John W. Linville committed Mar 28, 2009
1 parent cee075a commit b5bde37
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions net/mac80211/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -161,12 +161,6 @@ int ieee80211_if_config(struct ieee80211_sub_if_data *sdata, u32 changed)
if (WARN_ON(!netif_running(sdata->dev)))
return 0;

if (WARN_ON(sdata->vif.type == NL80211_IFTYPE_AP_VLAN))
return -EINVAL;

if (!local->ops->config_interface)
return 0;

memset(&conf, 0, sizeof(conf));

if (sdata->vif.type == NL80211_IFTYPE_STATION)
Expand All @@ -183,6 +177,9 @@ int ieee80211_if_config(struct ieee80211_sub_if_data *sdata, u32 changed)
return -EINVAL;
}

if (!local->ops->config_interface)
return 0;

switch (sdata->vif.type) {
case NL80211_IFTYPE_AP:
case NL80211_IFTYPE_ADHOC:
Expand Down Expand Up @@ -224,9 +221,6 @@ int ieee80211_if_config(struct ieee80211_sub_if_data *sdata, u32 changed)
}
}

if (WARN_ON(!conf.bssid && (changed & IEEE80211_IFCC_BSSID)))
return -EINVAL;

conf.changed = changed;

return local->ops->config_interface(local_to_hw(local),
Expand Down

0 comments on commit b5bde37

Please sign in to comment.