Skip to content

Commit

Permalink
fsl-diu-fb: fix regression with uninitalized fb_info->mm_lock mutex
Browse files Browse the repository at this point in the history
Remove call to the fsl_diu_set_par before the register_framebuffer().

This fixes a problem with uninitialized the fb_info->mm_lock mutex
introduced by the commit 537a1bf " fbdev: add mutex for fb_mmap
locking"

Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Tested-by: "Kai Jiang" <b18973@freescale.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Krzysztof Helt authored and Linus Torvalds committed Jul 8, 2009
1 parent 44b5728 commit b5daa70
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions drivers/video/fsl-diu-fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1223,12 +1223,6 @@ static int __devinit install_fb(struct fb_info *info)
return -EINVAL;
}

if (fsl_diu_set_par(info)) {
printk(KERN_ERR "fb_set_par failed");
fb_dealloc_cmap(&info->cmap);
return -EINVAL;
}

if (register_framebuffer(info) < 0) {
printk(KERN_ERR "register_framebuffer failed");
unmap_video_memory(info);
Expand Down

0 comments on commit b5daa70

Please sign in to comment.