Skip to content

Commit

Permalink
[media] Cleanup media Kconfig files
Browse files Browse the repository at this point in the history
- get rid of ridden V4L2_COMMON symbol

  This symbol is not needed anymore; it can be folded with V4L2
  one, simplifying the Kconfig a little bit;

- Comment why some Kconfig items are needed;

- Remove if test for MEDIA_CAMERA_SUPPORT, replacing it by
  depends on.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Aug 21, 2012
1 parent 7a46e18 commit b633446
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 22 deletions.
5 changes: 0 additions & 5 deletions drivers/media/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,6 @@ config VIDEO_DEV
depends on MEDIA_CAMERA_SUPPORT || MEDIA_ANALOG_TV_SUPPORT || MEDIA_RADIO_SUPPORT
default y

config VIDEO_V4L2_COMMON
tristate
depends on (I2C || I2C=n) && VIDEO_DEV
default (I2C || I2C=n) && VIDEO_DEV

config VIDEO_V4L2_SUBDEV_API
bool "V4L2 sub-device userspace API (EXPERIMENTAL)"
depends on VIDEO_DEV && MEDIA_CONTROLLER && EXPERIMENTAL
Expand Down
2 changes: 1 addition & 1 deletion drivers/media/i2c/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ comment "MPEG video encoders"

config VIDEO_CX2341X
tristate "Conexant CX2341x MPEG encoders"
depends on VIDEO_V4L2 && VIDEO_V4L2_COMMON
depends on VIDEO_V4L2
---help---
Support for the Conexant CX23416 MPEG encoders
and CX23415 MPEG encoder/decoders.
Expand Down
6 changes: 2 additions & 4 deletions drivers/media/platform/Kconfig
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
if MEDIA_CAMERA_SUPPORT

#
# Platform drivers
# All drivers here are currently for webcam support
Expand Down Expand Up @@ -37,6 +35,7 @@ source "drivers/media/platform/blackfin/Kconfig"

config VIDEO_SH_VOU
tristate "SuperH VOU video output driver"
depends on MEDIA_CAMERA_SUPPORT
depends on VIDEO_DEV && ARCH_SHMOBILE
select VIDEOBUF_DMA_CONTIG
help
Expand Down Expand Up @@ -119,6 +118,7 @@ endif # V4L_PLATFORM_DRIVERS
menuconfig V4L_MEM2MEM_DRIVERS
bool "Memory-to-memory multimedia devices"
depends on VIDEO_V4L2
depends on MEDIA_CAMERA_SUPPORT
default n
---help---
Say Y here to enable selecting drivers for V4L devices that
Expand Down Expand Up @@ -212,5 +212,3 @@ config VIDEO_MEM2MEM_TESTDEV
This is a virtual test device for the memory-to-memory driver
framework.
endif #V4L_TEST_DRIVERS

endif # MEDIA_CAMERA_SUPPORT
27 changes: 16 additions & 11 deletions drivers/media/v4l2-core/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@
# Generic video config states
#

# Enable the V4L2 core and API
config VIDEO_V4L2
tristate
depends on (I2C || I2C=n) && VIDEO_DEV
default (I2C || I2C=n) && VIDEO_DEV

config VIDEO_ADV_DEBUG
bool "Enable advanced debug functionality on V4L2 drivers"
default n
Expand All @@ -19,11 +25,17 @@ config VIDEO_FIXED_MINOR_RANGES

When in doubt, say N.

config VIDEO_V4L2
# Used by drivers that need tuner.ko
config VIDEO_TUNER
tristate
depends on VIDEO_V4L2_COMMON
default y
depends on MEDIA_TUNER

# Used by drivers that need v4l2-mem2mem.ko
config V4L2_MEM2MEM_DEV
tristate
depends on VIDEOBUF2_CORE

# Used by drivers that need Videobuf modules
config VIDEOBUF_GEN
tristate

Expand All @@ -45,14 +57,7 @@ config VIDEOBUF_DVB
tristate
select VIDEOBUF_GEN

config VIDEO_TUNER
tristate
depends on MEDIA_TUNER

config V4L2_MEM2MEM_DEV
tristate
depends on VIDEOBUF2_CORE

# Used by drivers that need Videobuf2 modules
config VIDEOBUF2_CORE
tristate

Expand Down
2 changes: 1 addition & 1 deletion drivers/media/v4l2-core/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ifeq ($(CONFIG_COMPAT),y)
endif

obj-$(CONFIG_VIDEO_DEV) += videodev.o v4l2-int-device.o
obj-$(CONFIG_VIDEO_V4L2_COMMON) += v4l2-common.o
obj-$(CONFIG_VIDEO_V4L2) += v4l2-common.o

obj-$(CONFIG_VIDEO_TUNER) += tuner.o

Expand Down

0 comments on commit b633446

Please sign in to comment.