Skip to content

Commit

Permalink
net: rename group sysfs entry to netdev_group
Browse files Browse the repository at this point in the history
commit a512b92 adds sysfs entry for net device group, but
before this commit, tun also uses group sysfs, so after this
commit checkin, kernel warns like this:
    sysfs: cannot create duplicate filename '/devices/virtual/net/vnet0/group'

Since tun has used this for years, rename sysfs under tun might
break existing userspace, so rename group sysfs entry for net device
group is a better choice.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Xiaotian Feng authored and David S. Miller committed Feb 10, 2011
1 parent 2705974 commit b6644cb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/core/net-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ static struct device_attribute net_class_attributes[] = {
__ATTR(flags, S_IRUGO | S_IWUSR, show_flags, store_flags),
__ATTR(tx_queue_len, S_IRUGO | S_IWUSR, show_tx_queue_len,
store_tx_queue_len),
__ATTR(group, S_IRUGO | S_IWUSR, show_group, store_group),
__ATTR(netdev_group, S_IRUGO | S_IWUSR, show_group, store_group),
{}
};

Expand Down

0 comments on commit b6644cb

Please sign in to comment.