Skip to content

Commit

Permalink
USB: mct_u232.c: remove dbg() tracing calls
Browse files Browse the repository at this point in the history
dbg() was used a lot a long time ago to trace code flow.  Now that we have
ftrace, this isn't needed at all, so remove these calls.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed May 3, 2012
1 parent f65ee14 commit b69919c
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions drivers/usb/serial/mct_u232.c
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,6 @@ static void mct_u232_release(struct usb_serial *serial)
struct mct_u232_private *priv;
int i;

dbg("%s", __func__);

for (i = 0; i < serial->num_ports; ++i) {
/* My special items, the standard routines free my urbs */
priv = usb_get_serial_port_data(serial->port[i]);
Expand All @@ -446,8 +444,6 @@ static int mct_u232_open(struct tty_struct *tty, struct usb_serial_port *port)
unsigned char last_lcr;
unsigned char last_msr;

dbg("%s port %d", __func__, port->number);

/* Compensate for a hardware bug: although the Sitecom U232-P25
* device reports a maximum output packet size of 32 bytes,
* it seems to be able to accept only 16 bytes (and that's what
Expand Down Expand Up @@ -528,8 +524,6 @@ static void mct_u232_dtr_rts(struct usb_serial_port *port, int on)

static void mct_u232_close(struct usb_serial_port *port)
{
dbg("%s port %d", __func__, port->number);

if (port->serial->dev) {
/* shutdown our urbs */
usb_kill_urb(port->write_urb);
Expand Down Expand Up @@ -572,7 +566,6 @@ static void mct_u232_read_int_callback(struct urb *urb)
return;
}

dbg("%s - port %d", __func__, port->number);
usb_serial_debug_data(debug, &port->dev, __func__,
urb->actual_length, data);

Expand Down Expand Up @@ -733,8 +726,6 @@ static void mct_u232_break_ctl(struct tty_struct *tty, int break_state)
unsigned char lcr;
unsigned long flags;

dbg("%sstate=%d", __func__, break_state);

spin_lock_irqsave(&priv->lock, flags);
lcr = priv->last_lcr;

Expand All @@ -753,8 +744,6 @@ static int mct_u232_tiocmget(struct tty_struct *tty)
unsigned int control_state;
unsigned long flags;

dbg("%s", __func__);

spin_lock_irqsave(&priv->lock, flags);
control_state = priv->control_state;
spin_unlock_irqrestore(&priv->lock, flags);
Expand All @@ -771,8 +760,6 @@ static int mct_u232_tiocmset(struct tty_struct *tty,
unsigned int control_state;
unsigned long flags;

dbg("%s", __func__);

spin_lock_irqsave(&priv->lock, flags);
control_state = priv->control_state;

Expand All @@ -796,8 +783,6 @@ static void mct_u232_throttle(struct tty_struct *tty)
struct mct_u232_private *priv = usb_get_serial_port_data(port);
unsigned int control_state;

dbg("%s - port %d", __func__, port->number);

spin_lock_irq(&priv->lock);
priv->rx_flags |= THROTTLED;
if (C_CRTSCTS(tty)) {
Expand All @@ -816,8 +801,6 @@ static void mct_u232_unthrottle(struct tty_struct *tty)
struct mct_u232_private *priv = usb_get_serial_port_data(port);
unsigned int control_state;

dbg("%s - port %d", __func__, port->number);

spin_lock_irq(&priv->lock);
if ((priv->rx_flags & THROTTLED) && C_CRTSCTS(tty)) {
priv->rx_flags &= ~THROTTLED;
Expand Down

0 comments on commit b69919c

Please sign in to comment.