Skip to content

Commit

Permalink
x86: apic.c x2apic_preenabled and disable_x2apic should be static
Browse files Browse the repository at this point in the history
Impact: cleanup, reduce kernel size a bit, avoid sparse warning

Fixes sparse warning:

  arch/x86/kernel/apic.c:103:5: warning: symbol 'disable_x2apic' was not declared. Should it be static?

Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Jaswinder Singh authored and Ingo Molnar committed Dec 27, 2008
1 parent 0b936bf commit b6b301a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/x86/include/asm/apic.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ static inline u32 native_apic_msr_read(u32 reg)
}

#ifndef CONFIG_X86_32
extern int x2apic, x2apic_preenabled;
extern int x2apic;
extern void check_x2apic(void);
extern void enable_x2apic(void);
extern void enable_IR_x2apic(void);
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/kernel/apic.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ __setup("apicpmtimer", setup_apicpmtimer);
#ifdef HAVE_X2APIC
int x2apic;
/* x2apic enabled before OS handover */
int x2apic_preenabled;
int disable_x2apic;
static int x2apic_preenabled;
static int disable_x2apic;
static __init int setup_nox2apic(char *str)
{
disable_x2apic = 1;
Expand Down

0 comments on commit b6b301a

Please sign in to comment.