Skip to content

Commit

Permalink
sky2: no message on rx fifo overflow
Browse files Browse the repository at this point in the history
Under high load it is possible to make the receiver FIFO get overloaded.
The driver/hardware recover properly, so there is no reason to fill the log
with lots of extra messages, just update counter.

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
  • Loading branch information
Stephen Hemminger committed Oct 17, 2006
1 parent 16ad91e commit b6d7773
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/net/sky2.c
Original file line number Diff line number Diff line change
Expand Up @@ -2014,6 +2014,10 @@ static struct sk_buff *sky2_receive(struct net_device *dev,

error:
++sky2->net_stats.rx_errors;
if (status & GMR_FS_RX_FF_OV) {
sky2->net_stats.rx_fifo_errors++;
goto resubmit;
}

if (netif_msg_rx_err(sky2) && net_ratelimit())
printk(KERN_INFO PFX "%s: rx error, status 0x%x length %d\n",
Expand All @@ -2025,8 +2029,6 @@ static struct sk_buff *sky2_receive(struct net_device *dev,
sky2->net_stats.rx_frame_errors++;
if (status & GMR_FS_CRC_ERR)
sky2->net_stats.rx_crc_errors++;
if (status & GMR_FS_RX_FF_OV)
sky2->net_stats.rx_fifo_errors++;

goto resubmit;
}
Expand Down

0 comments on commit b6d7773

Please sign in to comment.