Skip to content

Commit

Permalink
pca100: clean up GPIO pin multiplexing
Browse files Browse the repository at this point in the history
cleaned up some duplicated mxc_gpio_mode calls and move the correpsonding
pin multiplexing either into the initial pin config table or ifdef blocks.

Signed-off-by: Luotao Fu <l.fu@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
  • Loading branch information
Luotao Fu authored and Sascha Hauer committed Jul 26, 2010
1 parent 42216fc commit b725aba
Showing 1 changed file with 11 additions and 12 deletions.
23 changes: 11 additions & 12 deletions arch/arm/mach-mx2/mach-pca100.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@

#define OTG_PHY_CS_GPIO (GPIO_PORTB + 23)
#define USBH2_PHY_CS_GPIO (GPIO_PORTB + 24)
#define SPI1_SS0 (GPIO_PORTD + 28)
#define SPI1_SS1 (GPIO_PORTD + 27)
#define SD2_CD (GPIO_PORTC + 29)

static int pca100_pins[] = {
/* UART1 */
Expand All @@ -69,6 +72,7 @@ static int pca100_pins[] = {
PB7_PF_SD2_D3,
PB8_PF_SD2_CMD,
PB9_PF_SD2_CLK,
SD2_CD | GPIO_GPIO | GPIO_IN,
/* FEC */
PD0_AIN_FEC_TXD0,
PD1_AIN_FEC_TXD1,
Expand Down Expand Up @@ -156,6 +160,10 @@ static int pca100_pins[] = {
PA28_PF_HSYNC,
PA29_PF_VSYNC,
PA31_PF_OE_ACD,
/* free GPIO */
GPIO_PORTC | 31 | GPIO_GPIO | GPIO_IN, /* GPIO0_IRQ */
GPIO_PORTC | 25 | GPIO_GPIO | GPIO_IN, /* GPIO1_IRQ */
GPIO_PORTE | 5 | GPIO_GPIO | GPIO_IN, /* GPIO2_IRQ */
};

static struct imxuart_platform_data uart_pdata = {
Expand Down Expand Up @@ -214,7 +222,7 @@ static struct spi_board_info pca100_spi_board_info[] __initdata = {
},
};

static int pca100_spi_cs[] = {GPIO_PORTD + 28, GPIO_PORTD + 27};
static int pca100_spi_cs[] = {SPI1_SS0, SPI1_SS1};

static struct spi_imx_master pca100_spi_0_data = {
.chipselect = pca100_spi_cs,
Expand Down Expand Up @@ -388,7 +396,6 @@ static void __init pca100_init(void)

mxc_register_device(&mxc_uart_device0, &uart_pdata);

mxc_gpio_mode(GPIO_PORTC | 29 | GPIO_GPIO | GPIO_IN);
mxc_register_device(&mxc_sdhc_device1, &sdhc_pdata);

mxc_register_device(&imx27_nand_device, &pca100_nand_board_info);
Expand All @@ -399,17 +406,9 @@ static void __init pca100_init(void)

mxc_register_device(&mxc_i2c_device1, &pca100_i2c_1_data);

mxc_gpio_mode(GPIO_PORTD | 28 | GPIO_GPIO | GPIO_OUT);
mxc_gpio_mode(GPIO_PORTD | 27 | GPIO_GPIO | GPIO_OUT);

/* GPIO0_IRQ */
mxc_gpio_mode(GPIO_PORTC | 31 | GPIO_GPIO | GPIO_IN);
/* GPIO1_IRQ */
mxc_gpio_mode(GPIO_PORTC | 25 | GPIO_GPIO | GPIO_IN);
/* GPIO2_IRQ */
mxc_gpio_mode(GPIO_PORTE | 5 | GPIO_GPIO | GPIO_IN);

#if defined(CONFIG_SPI_IMX) || defined(CONFIG_SPI_IMX_MODULE)
mxc_gpio_mode(GPIO_PORTD | 28 | GPIO_GPIO | GPIO_IN);
mxc_gpio_mode(GPIO_PORTD | 27 | GPIO_GPIO | GPIO_IN);
spi_register_board_info(pca100_spi_board_info,
ARRAY_SIZE(pca100_spi_board_info));
mxc_register_device(&mxc_spi_device0, &pca100_spi_0_data);
Expand Down

0 comments on commit b725aba

Please sign in to comment.