Skip to content

Commit

Permalink
ARM: Avoid evaluating page_address() multiple times
Browse files Browse the repository at this point in the history
page_address() is a function call rather than a macro, and so:

	if (page_address(page))
		do_something(page_address(page));

results in two calls to this function.  This is unnecessary; remove
the duplication.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Dec 1, 2009
1 parent 2f0b192 commit b7dc0b2
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions arch/arm/mm/flush.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ void flush_ptrace_access(struct vm_area_struct *vma, struct page *page,

void __flush_dcache_page(struct address_space *mapping, struct page *page)
{
void *addr = page_address(page);

/*
* Writeback any data associated with the kernel mapping of this
* page. This ensures that data in the physical page is mutually
Expand All @@ -121,9 +123,9 @@ void __flush_dcache_page(struct address_space *mapping, struct page *page)
* kmap_atomic() doesn't set the page virtual address, and
* kunmap_atomic() takes care of cache flushing already.
*/
if (page_address(page))
if (addr)
#endif
__cpuc_flush_dcache_page(page_address(page));
__cpuc_flush_dcache_page(addr);

/*
* If this is a page cache page, and we have an aliasing VIPT cache,
Expand Down

0 comments on commit b7dc0b2

Please sign in to comment.