Skip to content

Commit

Permalink
PCI: x86: use generic pci_enable_resources()
Browse files Browse the repository at this point in the history
Use the generic pci_enable_resources() instead of the arch-specific code.

Unlike this arch-specific code, the generic version:
    - checks for resource collisions with "!r->parent"

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Bjorn Helgaas authored and Greg Kroah-Hartman committed Apr 21, 2008
1 parent 842de40 commit b81d988
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 40 deletions.
2 changes: 1 addition & 1 deletion arch/x86/pci/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
{
int err;

if ((err = pcibios_enable_resources(dev, mask)) < 0)
if ((err = pci_enable_resources(dev, mask)) < 0)
return err;

if (!dev->msi_enabled)
Expand Down
38 changes: 0 additions & 38 deletions arch/x86/pci/i386.c
Original file line number Diff line number Diff line change
Expand Up @@ -241,44 +241,6 @@ void __init pcibios_resource_survey(void)
*/
fs_initcall(pcibios_assign_resources);

int pcibios_enable_resources(struct pci_dev *dev, int mask)
{
u16 cmd, old_cmd;
int idx;
struct resource *r;

pci_read_config_word(dev, PCI_COMMAND, &cmd);
old_cmd = cmd;
for (idx = 0; idx < PCI_NUM_RESOURCES; idx++) {
/* Only set up the requested stuff */
if (!(mask & (1 << idx)))
continue;

r = &dev->resource[idx];
if (!(r->flags & (IORESOURCE_IO | IORESOURCE_MEM)))
continue;
if ((idx == PCI_ROM_RESOURCE) &&
(!(r->flags & IORESOURCE_ROM_ENABLE)))
continue;
if (!r->start && r->end) {
printk(KERN_ERR "PCI: Device %s not available "
"because of resource %d collisions\n",
pci_name(dev), idx);
return -EINVAL;
}
if (r->flags & IORESOURCE_IO)
cmd |= PCI_COMMAND_IO;
if (r->flags & IORESOURCE_MEM)
cmd |= PCI_COMMAND_MEMORY;
}
if (cmd != old_cmd) {
printk("PCI: Enabling device %s (%04x -> %04x)\n",
pci_name(dev), old_cmd, cmd);
pci_write_config_word(dev, PCI_COMMAND, cmd);
}
return 0;
}

/*
* If we set up a device for bus mastering, we need to check the latency
* timer as certain crappy BIOSes forget to set it properly.
Expand Down
1 change: 0 additions & 1 deletion arch/x86/pci/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ enum pci_bf_sort_state {
extern unsigned int pcibios_max_latency;

void pcibios_resource_survey(void);
int pcibios_enable_resources(struct pci_dev *, int);

/* pci-pc.c */

Expand Down

0 comments on commit b81d988

Please sign in to comment.